Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

186 add total records to submission #199

Merged
merged 4 commits into from
May 7, 2024
Merged

186 add total records to submission #199

merged 4 commits into from
May 7, 2024

Conversation

guffee23
Copy link
Contributor

@guffee23 guffee23 commented May 7, 2024

Closes #186

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/sbl_filing_api/entities/models
  dao.py
  dto.py
  src/sbl_filing_api/services
  submission_processor.py
Project Total  

This report was generated by python-coverage-comment-action

@guffee23 guffee23 requested review from jcadam14 and lchen-2101 May 7, 2024 18:09
jcadam14
jcadam14 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran through a local test of curling two different sized files, one with 2 entries that passes validation and one with 31620 entries that fails validation and both had a correct total_records in the submission

@jcadam14 jcadam14 merged commit bb2fd6d into main May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcadam14 jcadam14 jcadam14 approved these changes

@lchen-2101 lchen-2101 Awaiting requested review from lchen-2101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add total_records to Submission
2 participants
@guffee23 @jcadam14