Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

183 val json to results #193

Merged
merged 2 commits into from
May 2, 2024
Merged

183 val json to results #193

merged 2 commits into from
May 2, 2024

Conversation

guffee23
Copy link
Contributor

@guffee23 guffee23 commented May 1, 2024

Closes #183

@guffee23 guffee23 requested review from jcadam14 and lchen-2101 May 1, 2024 21:07
Copy link

github-actions bot commented May 1, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/sbl_filing_api/entities/models
  dao.py
  dto.py
  src/sbl_filing_api/services
  submission_processor.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Justin

inspector = sqlalchemy.inspect(alembic_engine)

assert "validation_results" in [c["name"] for c in inspector.get_columns("submission")]
assert "validation_json" not in [c["name"] for c in inspector.get_columns("submission")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome checking for the columns

@jcadam14 jcadam14 merged commit cf26810 into main May 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change validation_json to validation_results in SubmissionDAO/DTO/table
2 participants