fix: use boto3 #185
fix: use boto3 #185
Conversation
lchen-2101
requested review from
hkeeler,
guffee23,
jcadam14 and
nargis-sultani
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
| period_code, | ||
| file_identifier, | ||
| r, | ||
| ) | ||
| except Exception as e: | ||
| raise RegTechHttpException( | ||
| status_code=HTTPStatus.INTERNAL_SERVER_ERROR, name="Upload Failure", detail="Failed to upload file" |
There was a problem hiding this comment.
I don't think this needs to be done here, but just realized it's a little weird throwing an HttpException here when for one of the uploads, it's done outside of an http request handler. It eventually gets caught as a general Exception and logged, but something to consider for naming purposes.
There was a problem hiding this comment.
yeah, this one is a bit weird, part of it does come from the request, i.e. uploading the submission file; then the report file gets uploaded outside of the request context; we can dig into how to present this better later, but for now think it's fine, since the fastapi exception handler would deal with the actual http exception, and the validation process has a try catch to deal with it.
closes #184