170 add validation error if an unknown exception happens during validation #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
…s-during-validation'
lchen-2101
reviewed
Apr 19, 2024
tests/migrations/test_migrations.py
Outdated
Comment on lines
300
to
305
| def test_migration_to_0040045eae14(alembic_runner: MigrationContext, alembic_engine: Engine): | ||
| alembic_runner.migrate_up_to("0040045eae14") | ||
|
|
||
|
|
||
| def test_migration_to_c89920be2e66(alembic_runner: MigrationContext, alembic_engine: Engine): | ||
| alembic_runner.migrate_up_to("c89920be2e66") |
There was a problem hiding this comment.
these are the scripts specific to postgres as sqlite doesn't support type changes, right? I don't think we need to have just the empty tests here then, I think the imports at the top of the file cover them already if we just want to make sure the scripts run, but not worrying about the results:
from pytest_alembic.tests import (
test_single_head_revision, # noqa: F401
test_up_down_consistency, # noqa: F401
test_upgrade, # noqa: F401
)There was a problem hiding this comment.
Ok cool, yeah that was the purpose, just making sure the normal upgrade/downgrade alembic processes work, we don't have multiple heads, etc.
…tion-happens-during-validation
…tion-happens-during-validation
…tion-happens-during-validation
lchen-2101
deleted the
170-add-validation_error-if-an-unknown-exception-happens-during-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170