Added filename to FileResponse #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcadam14
requested review from
hkeeler,
lchen-2101,
natalia-fitzgerald and
nargis-sultani
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
lchen-2101
reviewed
Apr 16, 2024
src/sbl_filing_api/routers/filing.py
Outdated
| @@ -235,7 +235,7 @@ async def get_latest_submission_report(request: Request, lei: str, period_code: | |||
| file_data = await submission_processor.get_from_storage( | |||
| period_code, lei, str(latest_sub.id) + submission_processor.REPORT_QUALIFIER | |||
| ) | |||
| return FileResponse(path=file_data, media_type="text/csv") | |||
| return FileResponse(path=file_data, media_type="text/csv", filename=f"{latest_sub.id}validation_report.csv") | |||
There was a problem hiding this comment.
might be easier to read if we put a _ between the id and the suffix? e.g. 1_validation_report.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163