-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added submissions/latest/report and submissions/{id}/report, added pytest #144
Added submissions/latest/report and submissions/{id}/report, added pytest #144
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the one question.
I'm going to go ahead and mark it Approved. If you end up making the switch to FastAPI's FIleRepsonse
here, I can rereview when ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file intended to change for this PR? Is this just the result of pulling the latest from https://github.com/cfpb/regtech-data-validator.git and some other changes came along for the ride? I'm a little surprised content-hash
at the end of the file didn't change along with this. Maybe that doesn't change when the dependency is just referencing a git repo?
Poetry continues to make me go 🤔 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #138