Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Filing API action requirements check framework #482

Closed
lchen-2101 opened this issue Nov 5, 2024 · 0 comments · Fixed by #512
Closed

Create Filing API action requirements check framework #482

lchen-2101 opened this issue Nov 5, 2024 · 0 comments · Fixed by #512
Assignees
Labels
python Pull requests that update Python code

Comments

@lchen-2101
Copy link
Collaborator

lchen-2101 commented Nov 5, 2024

Create action requirement checks, so all relevant checks required for the action is done before returning a response; instead of having sequential failing requirement checks

Current behavior

Single requirement check fail stops the processing and responds with the single error causing the check to fail

Expected behavior

All requirement checks are done, so a list of checks can be in the response for corrective actions to be taken.

**Currently only need for sign and submit for the LEI status check; each check should be behind a feature flag (environment variable)

@lchen-2101 lchen-2101 self-assigned this Nov 14, 2024
@lchen-2101 lchen-2101 added the python Pull requests that update Python code label Dec 3, 2024
lchen-2101 added a commit that referenced this issue Dec 6, 2024
… sign and submit endpoint (#512)

closes #482
closes #515

new context, and validation dependency concept, currently only applying
to the `sign` endpoint, can extend to additional endpoints.

also removed some of the tasks code since we no longer going with that
concept; allowing for some daos to not be detached.

---------

Co-authored-by: jcadam14 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
1 participant