Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension to ContactInfo #420

Closed
Tracked by #265
jcadam14 opened this issue Sep 24, 2024 · 0 comments · Fixed by #421
Closed
Tracked by #265

Add extension to ContactInfo #420

jcadam14 opened this issue Sep 24, 2024 · 0 comments · Fixed by #421
Assignees
@jcadam14

Comments

@jcadam14
Copy link
Contributor

Update the ContactInfo data to include an extension field.

  • Create alembic script to add 'extension' to ContactInfo table. Field should be 254 characters. Field is optional.
  • Update ContactInfo DAO model to include extension field as a 254 string. Field is optional.
  • Update ContactInfo DTO to include extension field as string. Field is optional.
@jcadam14 jcadam14 self-assigned this Sep 24, 2024
@jcadam14 jcadam14 linked a pull request Sep 24, 2024 that will close this issue
Added extension field with a max size of 254 #421
Merged
@jcadam14 jcadam14 mentioned this issue Sep 24, 2024
Merged
jcadam14 added a commit that referenced this issue Sep 24, 2024
@jcadam14
Added extension field with a max size of 254 (#421)
fb78e33 
Closes #420 

- Added Alembic script to add the extension column to contact_info
- Added extension field to the contact info DAO and DTO
- Added pytests to test the two things above.
- Field is optional
@natalia-fitzgerald natalia-fitzgerald mentioned this issue Sep 26, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added extension field with a max size of 254 cfpb/sbl-filing-api
1 participant
@jcadam14