Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] get_latest_submission NPE when filing doesn't exist yet #178

Closed
lchen-2101 opened this issue Apr 24, 2024 · 0 comments · Fixed by #205
Closed

[WIP] get_latest_submission NPE when filing doesn't exist yet #178

lchen-2101 opened this issue Apr 24, 2024 · 0 comments · Fixed by #205
Assignees
@nargis-sultani
Labels
bug Something isn't working

Comments

@lchen-2101
Copy link
Collaborator

error log:

2024-04-23 14:31:54   File "/usr/local/lib/python3.12/site-packages/starlette/authentication.py", line 84, in async_wrapper
2024-04-23 14:31:54     return await func(*args, **kwargs)
2024-04-23 14:31:54            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-04-23 14:31:54   File "/usr/app/src/sbl_filing_api/routers/filing.py", line 182, in get_submission_latest
2024-04-23 14:31:54     result = await repo.get_latest_submission(request.state.db_session, lei, period_code)
2024-04-23 14:31:54              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-04-23 14:31:54   File "/usr/app/src/sbl_filing_api/entities/repos/submission_repo.py", line 46, in get_latest_submission
2024-04-23 14:31:54     stmt = select(SubmissionDAO).filter_by(filing=filing.id).order_by(desc(SubmissionDAO.submission_time)).limit(1)
@lchen-2101 lchen-2101 added the bug Something isn't working label Apr 24, 2024
@nargis-sultani nargis-sultani self-assigned this Apr 24, 2024
@nargis-sultani nargis-sultani mentioned this issue May 8, 2024
Merged
25 tasks
jcadam14 added a commit that referenced this issue May 9, 2024
@nargis-sultani @jcadam14
Task 178 - fix bug for get_latest_submission when filing does not exi…
761d45e 
…st (#205)

closes [#178 ](#178)
## Additions

-

## Removals

-

## Changes

-

## Testing

1.

## Screenshots


## Notes

-

## Todos

-

## Checklist

- [ ] PR has an informative and human-readable title
- [ ] Changes are limited to a single goal (no scope creep)
- [ ] Code can be automatically merged (no conflicts)
- [ ] Code follows the standards laid out in the [development
playbook](https://github.com/cfpb/development)
- [ ] Passes all existing automated tests
- [ ] Any _change_ in functionality is tested
- [ ] New functions are documented (with a description, list of inputs,
and expected output)
- [ ] Placeholder code is flagged / future todos are captured in
comments
- [ ] Visually tested in supported browsers and devices (see checklist
below 👇)
- [ ] Project documentation has been updated (including the "Unreleased"
section of the CHANGELOG)
- [ ] Reviewers requested with the [Reviewers
tool](https://help.github.com/articles/requesting-a-pull-request-review/)
:arrow_right:

## Testing checklist

### Browsers

- [ ] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Internet Explorer 8, 9, 10, and 11
- [ ] Edge
- [ ] iOS Safari
- [ ] Chrome for Android

### Accessibility

- [ ] Keyboard friendly
- [ ] Screen reader friendly

### Other

- [ ] Is useable without CSS
- [ ] Is useable without JS
- [ ] Flexible from small to large screens
- [ ] No linting errors or warnings
- [ ] JavaScript tests are passing

---------

Co-authored-by: Nargis Sultani <[email protected]>
Co-authored-by: jcadam14 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nargis-sultani nargis-sultani

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task 178 - fix bug for get_latest_submission when filing does not exist cfpb/sbl-filing-api
2 participants
@lchen-2101 @nargis-sultani