Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into setting time limit on background validation task #131

Closed
jcadam14 opened this issue Mar 26, 2024 · 0 comments · Fixed by #159
Closed

Look into setting time limit on background validation task #131

jcadam14 opened this issue Mar 26, 2024 · 0 comments · Fixed by #159
Assignees

Comments

@jcadam14
Copy link
Contributor

Look into possibility of background task hanging during validation, and if we can set a timeout limit.

@jcadam14 jcadam14 self-assigned this Apr 11, 2024
lchen-2101 pushed a commit that referenced this issue Apr 18, 2024
Closes #131 

- Added fastapil-utilities, which includes an async @retry_every
decorator.
- Added env vars to set the interval we check expired submissions, and
the time diff from time now to check if something is considered expired
- Added repo function to query over SUBMISSION_STARTED,
SUBMISSION_UPLOADED, and VALIDATION_IN_PROGRESS and check the
submission_time to time now, and set to VALIDATION_EXPIRED if greater
- I used submission_time, which I think is going to be moved under
submitter, since the times between START, UPLOADED and IN_PROGRESS are
relatively tiny. We don't capture or update a timestamp based on state
transitions so I figured for this, it was 'good enough'.
- Added new state to enum and alembic script for db update
- Added pytests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant