Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 422 on put("/institutions/{lei}/filings/{period_name}/institution-snapshot-id") if Filing doesn't exist #112

Closed
jcadam14 opened this issue Mar 15, 2024 · 0 comments · Fixed by #118
Closed

Return 422 on put("/institutions/{lei}/filings/{period_name}/institution-snapshot-id") if Filing doesn't exist #112

jcadam14 opened this issue Mar 15, 2024 · 0 comments · Fixed by #118
Assignees
@nargis-sultani

Comments

@jcadam14
Copy link
Contributor

Need to return a 422_UNPROCESSABLE_ENTITY instaed of 402 NO CONTENT if someone tries to update the snapshot id on a Filing that doesn't exist.

Ensure the response details/content returns a meaningful message stating the LEI and period that was attempting to be updated does not exist (with the actual lei and period from the URL)

Update pytest for test_patch_filing to check for 422 and the return message
@nargis-sultani nargis-sultani self-assigned this Mar 15, 2024
This was referenced Mar 18, 2024
Closed
Merged
jcadam14 pushed a commit that referenced this issue Mar 18, 2024
@nargis-sultani
Ticket 112 - Return 422 on put_institution_snapshot if a filing does … (
05e82dd 
#118)

…not exist

[Short description explaining the high-level reason for the pull
request]
closes [#112 ](#112)
## Additions

-

## Removals

-

## Changes

-

## Testing

1.

## Screenshots


## Notes

-

## Todos

-

## Checklist

- [ ] PR has an informative and human-readable title
- [ ] Changes are limited to a single goal (no scope creep)
- [ ] Code can be automatically merged (no conflicts)
- [ ] Code follows the standards laid out in the [development
playbook](https://github.com/cfpb/development)
- [ ] Passes all existing automated tests
- [ ] Any _change_ in functionality is tested
- [ ] New functions are documented (with a description, list of inputs,
and expected output)
- [ ] Placeholder code is flagged / future todos are captured in
comments
- [ ] Visually tested in supported browsers and devices (see checklist
below 👇)
- [ ] Project documentation has been updated (including the "Unreleased"
section of the CHANGELOG)
- [ ] Reviewers requested with the [Reviewers
tool](https://help.github.com/articles/requesting-a-pull-request-review/)
:arrow_right:

## Testing checklist

### Browsers

- [ ] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Internet Explorer 8, 9, 10, and 11
- [ ] Edge
- [ ] iOS Safari
- [ ] Chrome for Android

### Accessibility

- [ ] Keyboard friendly
- [ ] Screen reader friendly

### Other

- [ ] Is useable without CSS
- [ ] Is useable without JS
- [ ] Flexible from small to large screens
- [ ] No linting errors or warnings
- [ ] JavaScript tests are passing

Co-authored-by: Nargis Sultani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nargis-sultani nargis-sultani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ticket 112 - Return 422 on put_institution_snapshot if a filing does … cfpb/sbl-filing-api
2 participants
@jcadam14 @nargis-sultani