Merge branch 'main' into 503-add-ujson-to-locust-dockerfile

cfpb · Nov 25, 2024 · 1a72cea · 1a72cea
2 parents 842de00 + 26cc187
commit 1a72cea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/sbl_filing_api/entities/models/dto.py b/src/sbl_filing_api/entities/models/dto.py
@@ -28,13 +28,6 @@ class SubmissionDTO(BaseModel):
     submitter: UserActionDTO
     accepter: UserActionDTO | None = None
 
-    @model_validator(mode="after")
-    def validate_fi(self) -> "SubmissionDTO":
-        print(f"Self: {self}")
-        self.id = self.counter
-        print(f"Self: {self}")
-        return self
-
 
 class FilingTaskDTO(BaseModel):
     model_config = ConfigDict(from_attributes=True)

diff --git a/tests/api/routers/test_filing_api.py b/tests/api/routers/test_filing_api.py
@@ -977,7 +977,8 @@ async def test_accept_submission(self, mocker: MockerFixture, app_fixture: FastA
         )
 
         assert res.json()["state"] == "SUBMISSION_ACCEPTED"
-        assert res.json()["id"] == 4
+        assert res.json()["id"] == 1
+        assert res.json()["counter"] == 4
         assert res.json()["accepter"]["id"] == 3
         assert res.json()["accepter"]["user_id"] == "1234-5678-ABCD-EFGH"
         assert res.json()["accepter"]["user_name"] == "test accepter"