Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add django-dotenv, and compensate for the removal of drama-free-django runtime features #5133

Closed
wants to merge 21 commits into from
Closed

add django-dotenv, and compensate for the removal of drama-free-django runtime features #5133

wants to merge 21 commits into from

Commits on Jul 30, 2019

  1. use manage.py in docker/drama-free-django/test.sh

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    c2a7fec View commit details
    Browse the repository at this point in the history

  2. first step to removing DFD runtime dependencies: 

    use django-dotenv to load environment variables
    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    0bac8bb View commit details
    Browse the repository at this point in the history

  3. adapt to DFD's magic-removal-branch

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    e0d7e63 View commit details
    Browse the repository at this point in the history

  4. restore dotenv to manage.py

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    e059b34 View commit details
    Browse the repository at this point in the history

  5. address PR feedback

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    b742ce0 View commit details
    Browse the repository at this point in the history

  6. remove commented line

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    6dfc1cd View commit details
    Browse the repository at this point in the history

  7. implement DFD's json-reading behavior, if .env is not found

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    f9a697b View commit details
    Browse the repository at this point in the history

  8. a more useful default STATIC_ROOT

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    3dcfcdd View commit details
    Browse the repository at this point in the history

  9. make isort happy

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    32ce5ff View commit details
    Browse the repository at this point in the history

  10. use map instead of list comprehension 

    Co-Authored-By: Andy Chosak <[email protected]>
    @rosskarchner @chosak
    rosskarchner and chosak committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    ee15ba4 View commit details
    Browse the repository at this point in the history

  11. use override=True when calling dotenv.read_env 

    Also, remove some redundencies.
    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    a05951d View commit details
    Browse the repository at this point in the history

  12. move environment loading to settings, remove logic from .env_SAMPLE

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    be33dde View commit details
    Browse the repository at this point in the history

  13. Try a gentler approach to magic removal

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    dc1e285 View commit details
    Browse the repository at this point in the history

  14. decided to just keep using dfd's magic-removal-branch

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    3230f3b View commit details
    Browse the repository at this point in the history

  15. remove commented line

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    7aa3ac7 View commit details
    Browse the repository at this point in the history

  16. add a production_wsgi.py

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    6c40c7b View commit details
    Browse the repository at this point in the history

  17. local is not production

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    bbec250 View commit details
    Browse the repository at this point in the history

  18. use DFD master

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    3ed7f0b View commit details
    Browse the repository at this point in the history

  19. don't use override=True

    @rosskarchner
    rosskarchner committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    1122b4b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. default DJANGO_SETTINGS_MODULE is now production

    @rosskarchner
    rosskarchner committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    f502a5c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into magic-removal-branch

    @rosskarchner
    rosskarchner authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b1ea93e View commit details
    Browse the repository at this point in the history