-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runalerts in cf-reactor #2878
Merged
Merged
Runalerts in cf-reactor #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-reactor now takes care of running alerts periodically. Ticket: ENT-11538 Changelog: None
This was referenced Apr 26, 2024
nickanderson
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion to switch to concat()
to deal with multi-line comment attribute but not necessary.
craigcomstock
approved these changes
Apr 29, 2024
Since version 3.24.0 running alerts is part of cf-reactor. Ticket: ENT-11538 Changelog: None
vpodzime
force-pushed
the
master-no_cf_runalerts
branch
from
April 30, 2024 12:31
c4b407b
to
da5779e
Compare
comment => concat("To run PHP runalerts to check bundle status on SQL and Sketch.", | ||
" ENT-5432: must run after cfe_internal_enterprise_maintenance bundle", | ||
" so that active_hub class is determined. Since version 3.24.0 running", | ||
" alerts is part of cf-reactor"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
nickanderson
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together:
https://github.com/cfengine/nova/pull/2208
cfengine/core#5487
#2878
cfengine/buildscripts#1407