Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runalerts in cf-reactor #2878

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

vpodzime
Copy link
Contributor

@vpodzime vpodzime commented Apr 26, 2024

cf-reactor now takes care of running alerts periodically.

Ticket: ENT-11538
Changelog: None
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to switch to concat() to deal with multi-line comment attribute but not necessary.

Since version 3.24.0 running alerts is part of cf-reactor.

Ticket: ENT-11538
Changelog: None
comment => concat("To run PHP runalerts to check bundle status on SQL and Sketch.",
" ENT-5432: must run after cfe_internal_enterprise_maintenance bundle",
" so that active_hub class is determined. Since version 3.24.0 running",
" alerts is part of cf-reactor"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@vpodzime vpodzime merged commit 9e96fcf into cfengine:master May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants