libpromises/evalfunction: Do not crash w/o arguments #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btriller
force-pushed
the
evalfuntion-crash
branch
2 times, most recently
from
51f4289
to
8979788
Compare
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsewi
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Great, thanks 🚀 You can easily fix the CodeQL alerts by adding
assert(fp != NULL);in the top of the function block. Let me know if you want me to fix this for you.
In the mean while we can ask @cf-bottom to test this in Jenkins
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11443/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11443/ |
Do not crash cf-promises if no argument is given for following functions: * readfile * iprange * isipinsubnet
btriller
force-pushed
the
evalfuntion-crash
branch
from
8979788
to
e040d7f
Compare
larsewi
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not crash cf-promises if no argument is given for following functions: