Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10830: Build steps no longer write duplicate entries to def.json where appropriate #201

Merged
merged 1 commit into from
Aug 14, 2024
Merged

ENT-10830: Build steps no longer write duplicate entries to def.json where appropriate #201

merged 1 commit into from
Aug 14, 2024

Conversation

jakub-nt
Copy link
Contributor

No description provided.

@cf-bottom
Copy link

Thanks for submitting a PR! Maybe @larsewi can review this?

olehermanse
olehermanse requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as noted in Slack, please add a sentence or two about this in JSON.md.

larsewi
larsewi approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🚀

olehermanse
olehermanse requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just one suggestion to improve the documentation.

JSON.md Outdated Show resolved Hide resolved
nickanderson
nickanderson previously requested changes Aug 10, 2024
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. But the last commit description could be improved, or perhaps better squash this all into a single commit.

@olehermanse olehermanse merged commit a59de39 into cfengine:master Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsewi larsewi larsewi approved these changes

@olehermanse olehermanse olehermanse approved these changes

@nickanderson nickanderson Awaiting requested review from nickanderson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakub-nt @cf-bottom @nickanderson @olehermanse @larsewi