Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-963: Remove ping_reviewers_dependabot from mender integration #97

Merged

Conversation

lluiscampos
Copy link
Contributor

@lluiscampos lluiscampos commented Dec 8, 2023

We don't need this feature anymore as we are using dependabot's built-in functionality

@olehermanse
Copy link
Member

We were not making use of report_open_prs feature, so remove the whole integration.

@lluiscampos this is not true, we are using this. Please see:

https://northerntech.atlassian.net/browse/SEC-879
https://northerntech.atlassian.net/browse/SEC-917
https://northerntech.atlassian.net/browse/SEC-918

config.json Show resolved Hide resolved
We don't need this feature anymore as we are using `dependabot`'s
built-in functionality

Signed-off-by: Lluis Campos <[email protected]>
@lluiscampos lluiscampos force-pushed the SEC-963-remove-dependabot-mender branch from 61421df to 40c3102 Compare December 22, 2023 09:44
@lluiscampos
Copy link
Contributor Author

@lluiscampos this is not true, we are using this. Please see:

My apologies, I thought that because we had no set reviewers in the configuration it was in effect not working.

I reverted it now, just in time for Christmas 💝

@lluiscampos lluiscampos changed the title SEC-963: Remove mendersoftware integration from the configuration SEC-963: Remove ping_reviewers_dependabot from mender integration Dec 22, 2023
Should not have been removed in previous commit.
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made another fix, "orgs" should not be removed. Looks good now.

@olehermanse olehermanse merged commit 1dd52b2 into cfengine:master Jan 2, 2024
5 checks passed
@lluiscampos lluiscampos deleted the SEC-963-remove-dependabot-mender branch January 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants