Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mio dependency to 0.7 to get rid of net2 dependency #12

Closed
clintfred opened this issue Jun 1, 2020 · 6 comments
Closed

Bump mio dependency to 0.7 to get rid of net2 dependency #12

clintfred opened this issue Jun 1, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@clintfred
Copy link

See https://rustsec.org/advisories/RUSTSEC-2020-0016.html

Since there isn't a 0.6.x version of mio that doesn't have net2, there may be other breaking changes to absorb.

@cetra3
Copy link
Owner

cetra3 commented Jun 1, 2020

Yep, good idea! I think we might need to wait until tokio itself uses mio 0.7.

@cetra3 cetra3 added the enhancement New feature or request label Jun 1, 2020
@clintfred
Copy link
Author

Here's the tokio mio 0.7 issue for reference

@cetra3
Copy link
Owner

cetra3 commented Jan 6, 2021

@clintfred can you confirm if this has been resolved in tokio 1.0? I have just merged this PR If so can you close off this issue.

@clintfred
Copy link
Author

Since #19 removed the direct dependency on mio, and tokio 1.0.1 depends on mio 0.7.7 (which doesn't use net2), I think everything should be good.

Thanks!

Curious: why was the direct dependency on on mio able to be removed?

@skrap
Copy link
Collaborator

skrap commented Jan 7, 2021

Curious: why was the direct dependency on on mio able to be removed?

Tokio 1.0 has an API (AsyncFd) which allows it to integrate a raw file descriptor into the event loop. I think it's just implemented in mio internally within Tokio. This was done to avoid an API dependency on the interface to as-yet-not-stabilized mio crate.

@cetra3
Copy link
Owner

cetra3 commented Jan 7, 2021

Yep as @skrap mentioned we could use tokio itself to implement the glue rather than having to use mio. I'll close this issue off.

@cetra3 cetra3 closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants