-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mio dependency to 0.7 to get rid of net2 dependency #12
Comments
Yep, good idea! I think we might need to wait until |
Here's the tokio mio 0.7 issue for reference |
@clintfred can you confirm if this has been resolved in tokio 1.0? I have just merged this PR If so can you close off this issue. |
Since #19 removed the direct dependency on mio, and tokio 1.0.1 depends on mio 0.7.7 (which doesn't use net2), I think everything should be good. Thanks! Curious: why was the direct dependency on on mio able to be removed? |
Tokio 1.0 has an API ( |
Yep as @skrap mentioned we could use tokio itself to implement the glue rather than having to use mio. I'll close this issue off. |
See https://rustsec.org/advisories/RUSTSEC-2020-0016.html
Since there isn't a 0.6.x version of mio that doesn't have
net2
, there may be other breaking changes to absorb.The text was updated successfully, but these errors were encountered: