Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio: update to mio 0.7 #1190

Closed
carllerche opened this issue Jun 25, 2019 · 13 comments
Closed

tokio: update to mio 0.7 #1190

carllerche opened this issue Jun 25, 2019 · 13 comments
Assignees
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Milestone

Comments

@carllerche
Copy link
Member

Mio 0.7 is not yet released. The tokio master branch should depend on the mio master branch and track changes.

@carllerche carllerche added this to the v0.2 milestone Jun 25, 2019
@carllerche carllerche changed the title Update to mio 0.7 chore: update to mio 0.7 Jun 25, 2019
@carllerche carllerche changed the title chore: update to mio 0.7 tokio: update to mio 0.7 Jun 25, 2019
@carllerche carllerche removed this from the v0.2 milestone Nov 22, 2019
@Razican
Copy link
Contributor

Razican commented Jan 24, 2020

Hello, is there news on this regard?

@carllerche
Copy link
Member Author

It is a goal for 0.3, which should be sometime next month. There are still some windows issues to work through.

@galich
Copy link

galich commented Mar 12, 2020

Current version of tokio refers to winapi 0.3 and mio 0.6, which refers to winapi 0.2. We have 2 versions of fairly large winapi crate to build every time.

@carllerche is there any specific issue we can try and help with to make mio 0.7 used in tokio faster?

@Emilgardis
Copy link

Emilgardis commented Apr 10, 2020

mio 0.7.0 is now released. tokio-rs/mio#1279
Is there a timeline done for this?

@Stammark
Copy link

Stammark commented May 21, 2020

+1 for this from me!

Although to resolve winapi issues, the mio-named-pipes dependency would also have to be updated, too, probably (?) (see bbqsrc/mio-named-pipes#7).

edit: Thank you @Darksonn , sorry I hadn't spotted the other issue!

@Darksonn
Copy link
Contributor

Regarding mio-named-pipes: #2547

@Darksonn Darksonn reopened this May 21, 2020
@Darksonn
Copy link
Contributor

oops

@jmagnuson
Copy link

PR for updating mio-named-pipes: bbqsrc/mio-named-pipes#10

Previous work to update tokio to mio 0.7: #1767

@damianwadley
Copy link

Note that mio 0.6 contains an indirect dependency (via miow 0.2) on net2, which has been deprecated in favor of socket2 since earlier this month. cargo audit is also warning about it.
mio 0.7 (miow 0.3) has already moved to socket2.

@oherrala
Copy link

oherrala commented Jun 9, 2020

Borrowing this issue to mention that mio 0.7.0 release fixes a memory leak in Windows.

Upstream issue: tokio-rs/mio#919

Issues hopefully solved by updating tokio's mio to 0.7.0 based on the issue and crate's dependency to tokio:

@faern
Copy link
Contributor

faern commented Sep 3, 2020

Any updates here? Getting rid of mio 0.6 is certainly desirable.

@carllerche
Copy link
Member Author

Planned as part of 0.3

@carllerche carllerche mentioned this issue Sep 24, 2020
10 tasks
@carllerche carllerche self-assigned this Sep 24, 2020
@taiki-e
Copy link
Member

taiki-e commented Oct 4, 2020

Closing -- done in #2893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests