generated from runelite/example-plugin
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Rework #31
Open
cesoun
wants to merge
8
commits into
master
Choose a base branch
from
rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Plugin Rework #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump lombok and gradle to match the versions found in the example-plugin. Alos bumped plugin RL version to 1.8.18.4
cesoun
added
enhancement
New feature or request
upcoming
New or Upcoming Quests waiting on Wiki changes
labels
May 1, 2022
This was
linked to
issues
May 1, 2022
Open
Added new models for updated data type. Added utility function for loading the quest JSON. Updated quests.json with new most recent wiki changes.
Added additional checks in DataLoader for R&J and a Task
Activity tracks quest & task count. This will tell us how many rows we want to have in our grid. Guide uses GuidePlugin instead of GuidePanel class. Panels are coming along so far so good. Still quite a bit to go as well as some testing to ensure they work.
Wrote this in the airport so it might be all over the place. Wll be switching back over to my desktop to finish this.
This should be fairly close to what I want the plugin to look like. I have to accept that there are like 3 pixels that I cannot control inside of a DynamicGridLayout however it is likely that I just don't know what I am doing. I might merge the Requirement & Reward Panels into one since they are likely going to look very similar. Need to add in config settings and we should be good to go for adding the event handlers and updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
back burner
A feature that is not a priority.
enhancement
New feature or request
upcoming
New or Upcoming Quests waiting on Wiki changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starter PR for changes to come.
Bump lombok and gradle to match the versions found in the
example-plugin.
Also bumped plugin RL version to 1.8.18.4