Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Rework #23

Open
cesoun opened this issue Jun 3, 2021 · 1 comment · May be fixed by #31
Open

Plugin Rework #23

cesoun opened this issue Jun 3, 2021 · 1 comment · May be fixed by #31
Assignees
Labels
back burner A feature that is not a priority. enhancement New feature or request upcoming New or Upcoming Quests waiting on Wiki changes

Comments

@cesoun
Copy link
Owner

cesoun commented Jun 3, 2021

I want to reformat the look of things to make it a bit more uniform and allow for some extra information within each of the quests.

This would ideally look something like:

quest name
colored skill requirement [] | button for more info

This would make things a bit more similar in size and allow for more information about a given quest. It is also simple enough to allow adding all the "Additional Information" & "Location" columns in the wiki.

I am going to backburner this for now as I also want to come up with a method for updating the quests.json daily without needing to change it within the repository. This would mean the plugin ships with a fallback version and works with a more "live" version of the file if available.

@cesoun cesoun added enhancement New feature or request back burner A feature that is not a priority. labels Jun 3, 2021
@cesoun cesoun self-assigned this Jun 3, 2021
@cesoun
Copy link
Owner Author

cesoun commented Apr 30, 2022

I had to re-write my parser for the wiki and finally have hit a break to be able to get work done on this.

I will open the repository for the parser once I confirm it is working as intended. It isn't pretty so glhf 😃!

Items that will be ignored for with this refactor:

  • Additional Info
    • This column is useful, however requires additional processing that I am too lazy to do at the moment. I will consider it outside of the scope until I can come up with something better. In the meantime there are other plugins that fill this void. (Zoinkwiz Quest Helper)

The quests.json format will also be changing to contain more data related to each entry in the optimal quest guide table. Below is the format in the new parser.

A task is any row in the guide that contains train or trains from level x to level y. The plugin will display the task as long as the player is under the to level y value. The condition will be if the Requirements level has been met or exceeded.

Tasks will also contain a toggle to hide them if desired.

// Guide defines an array of activities
type Guide []Activity

// Activity defines an entry in the guide
type Activity struct {
	Index            int
	IsTask           bool
	Name             string
	GuideURL         string
	HasQuickGuide    bool
	QuickGuideURL    string
	Rewards          []Reward
	QuestPoints      int
	TotalQuestPoints int
	Location         string
	Requirements     []Requirement
}

// Reward defines an activity reward
type Reward struct {
	Level int
	Skill string
}

// Requirement defines a quest skill requirement
type Requirement struct {
	Level     int
	Skill     string
	Boostable bool
}

Once complete this should close the following issues:

As well as add support for:

@cesoun cesoun removed the back burner A feature that is not a priority. label Apr 30, 2022
@cesoun cesoun changed the title UI Panel Rework Plugin Rework Apr 30, 2022
@cesoun cesoun added the upcoming New or Upcoming Quests waiting on Wiki changes label Apr 30, 2022
@cesoun cesoun pinned this issue May 1, 2022
@cesoun cesoun linked a pull request May 1, 2022 that will close this issue
@cesoun cesoun added the back burner A feature that is not a priority. label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back burner A feature that is not a priority. enhancement New feature or request upcoming New or Upcoming Quests waiting on Wiki changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant