Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with upcoming update of InteratomicPotentials.jl #58

Merged
merged 15 commits into from
Jan 8, 2024

Conversation

emmanuellujan
Copy link
Member

@emmanuellujan emmanuellujan commented Dec 24, 2023

  • Changes required to make PotentialLearning.jl compatible with the upcoming update of InteratomicPotentials (see PR).
  • Other minor modifications were introduced, such as replacing copyto! with .=.

@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (9e27c3b) 44.67% compared to head (9396123) 44.07%.

❗ Current head 9396123 differs from pull request most recent head aca727a. Consider uploading reports for the commit aca727a to get more accurate results

Files Patch % Lines
src/Data/utils.jl 21.73% 18 Missing ⚠️
src/Learning/linear-learn.jl 65.00% 7 Missing ⚠️
src/Learning/linear-learning-problem.jl 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   44.67%   44.07%   -0.61%     
==========================================
  Files          24       23       -1     
  Lines         761      776      +15     
==========================================
+ Hits          340      342       +2     
- Misses        421      434      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmanuellujan emmanuellujan requested a review from swyant January 5, 2024 04:56
Copy link
Member

@swyant swyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@emmanuellujan emmanuellujan merged commit 4915d98 into main Jan 8, 2024
6 checks passed
@emmanuellujan emmanuellujan deleted the IP_compat branch January 8, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants