-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge InteratomicBasisPotentials.jl into InteratomicPotentials.jl + Updates from PotentialLearning.jl #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump version
Replaced ArbitraryPotential -> AbstractPotential, removed parameter info. Need to update how parameters are handled to match IP.jl interface.
update for InteratomicPotentials v0.2 compatibility
Update documentation and api for potentials.
Update to v0.2.0
Update documentation
Add workflows
Add JuliaMolSim to workflow registries.
Update index.md
Update docs
Update manifest
Update CI.yml
…otentials In preparation for some clean up, I have restructured the code base significant. ACE and SNAP now refer to BasisSystems, methods that compute local and force descriptors. The potentials are now classified as methods that take in a configuration and a basis system and return an energy, force, or virial. New examples of BasisPotentials include the LinearBasisPotential (which used to be referred to as ACE and SNAP) as well as the NeuralNetworkBasisPotential, that uses a neural network.
…B in nn potential.
swyant
requested changes
Dec 11, 2023
emmanuellujan
commented
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requested changes were addressed.
emmanuellujan
requested review from
swyant
and removed request for
joannajzou
December 21, 2023 21:23
swyant
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.