Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge InteratomicBasisPotentials.jl into InteratomicPotentials.jl + Updates from PotentialLearning.jl #50

Merged
merged 77 commits into from
Jan 4, 2024

Conversation

emmanuellujan
Copy link
Member

No description provided.

dallasfoster and others added 30 commits February 3, 2022 16:18
bump version
Replaced ArbitraryPotential -> AbstractPotential, removed parameter info. Need to update how parameters are handled to match IP.jl interface.
update for InteratomicPotentials v0.2 compatibility
Update documentation and api for potentials.
Add JuliaMolSim to workflow registries.
…otentials

In preparation for some clean up, I have restructured the code base significant. ACE and SNAP now refer to BasisSystems, methods that compute local and force descriptors. The potentials are now classified as methods that take in a configuration and a basis system and return an energy, force, or virial. New examples of BasisPotentials include the LinearBasisPotential (which used to be referred to as ACE and SNAP) as well as the NeuralNetworkBasisPotential, that uses a neural network.
Project.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/BasisPotentials/basis_potentials.jl Outdated Show resolved Hide resolved
src/BasisPotentials/basis_potentials.jl Show resolved Hide resolved
src/BasisSystems/ACE/ace.jl Outdated Show resolved Hide resolved
src/BasisSystems/ACE/ace.jl Show resolved Hide resolved
src/BasisSystems/SNAP/snap.jl Outdated Show resolved Hide resolved
src/api.jl Show resolved Hide resolved
Copy link
Member Author

@emmanuellujan emmanuellujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes were addressed.

@emmanuellujan emmanuellujan merged commit 973e0d5 into main Jan 4, 2024
4 checks passed
@emmanuellujan emmanuellujan deleted the IP_IBP branch January 8, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants