-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on invalid LAMMPS instance #62
Conversation
Ah interesting, so the issue with checking before an operation is that the error is "far" away from the original location. |
The main issue I'm adressing here is that it's not valid to pass null pointers as the handle for a lammps instance (with very few exceptions). Doing this currently causes a crash. I've decided to include this check in the |
Actually we can define next to our
So that whenever a LMP instance is passed to a C-API we emit an error check. |
Co-authored-by: Valentin Churavy <[email protected]>
I've taken a few things from #34 and made sure that we check the lammps instance before using it for all of our public API