Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #41

Merged
merged 6 commits into from
Apr 21, 2022
Merged

Documentation #41

merged 6 commits into from
Apr 21, 2022

Conversation

jrdegreeff
Copy link
Member

@jrdegreeff jrdegreeff commented Apr 18, 2022

This PR addresses #40. I have mostly addressed items 2 and 3 on the checklist and have created stubs for items 1 and 4 for @dallasfoster to complete. I am unsure what the existing example system (examples/LJCluster) is, so I have not touched that. This PR shouldn't be merged until all of the TODOs are resolved.

@jrdegreeff jrdegreeff requested a review from dallasfoster April 18, 2022 18:22
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #41 (e3220c8) into main (749d79a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          154       154           
=========================================
  Hits           154       154           
Impacted Files Coverage Δ
src/empirical/coulomb.jl 100.00% <ø> (ø)
src/empirical/lj.jl 100.00% <ø> (ø)
src/empirical/morse.jl 100.00% <ø> (ø)
src/empirical/zbl.jl 100.00% <ø> (ø)
src/mixed/linear_combination_potential.jl 100.00% <ø> (ø)
src/empirical/bm.jl 100.00% <100.00%> (ø)
src/nnlist.jl 100.00% <100.00%> (ø)
src/types/abstract_potential.jl 100.00% <100.00%> (ø)
src/types/empirical_potential.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749d79a...e3220c8. Read the comment docs.

@jrdegreeff jrdegreeff changed the title add documentation stubs everywhere Documentation Apr 19, 2022
@vchuravy
Copy link
Member

vchuravy commented Apr 19, 2022

Can you rebaseon master quickly? I want to make sure that the docs CI job actually runs

docs/src/interface.md Outdated Show resolved Hide resolved
@dallasfoster dallasfoster merged commit 878cc8f into main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants