Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Změna TSLint na ESlint a vyčištění repozitáře #66

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Změna TSLint na ESlint a vyčištění repozitáře #66

merged 1 commit into from
Oct 23, 2020

Conversation

HormCodes
Copy link
Member

@HormCodes HormCodes commented Oct 18, 2020 •
edited
Loading

  • Hlavní část je změna TSLint na ESLint. TSLint byl označen jako deprecated. Nejsem si jist, zda jsem otypoval komponenty správně - zde uvítám větší pozornost.
  • Odstranil jsem NetlifyCMS. Zatím není plán ho použít a není jisté, zda bude potřeba. Nepotřebný kód nepatří do repozitáře.
  • Odstranění nepoužitých závislostí. Snažil jsem se je zběžně projít. Je možné, že v zápětí některé přidáme, pokud se ukáže, že budou potřeba.

@vercel
Copy link

vercel bot commented Oct 18, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ceskodigital/web/2g1tg94x7
✅ Preview: https://web-git-refactoring-reworktslinttoeslint.ceskodigital.vercel.app

@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from b472985 to 12a00c9 Compare October 18, 2020 15:52
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from 12a00c9 to 31e4d6f Compare October 18, 2020 15:54
@HormCodes HormCodes changed the title Convert TSLint to ESLint and remove unused CMS Změna TSLint na ESlint a vyčištění repozitáře Oct 18, 2020
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from 31e4d6f to b779d10 Compare October 18, 2020 15:56
@HormCodes HormCodes marked this pull request as ready for review October 18, 2020 15:59
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from b779d10 to 71c0d09 Compare October 18, 2020 16:19
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from 71c0d09 to a5e2cc4 Compare October 18, 2020 16:29
miiila
miiila reviewed Oct 18, 2020
View reviewed changes
Copy link
Member

@miiila miiila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoustu odebraných řádků a víc typů, ideální pull request! Okomentoval jsem pár věcí, které mi nebyly jasné, není to ale nic velkého.

src/components/layout.tsx Outdated Show resolved Hide resolved
src/components/layout.tsx Outdated Show resolved Hide resolved
src/components/seo.tsx Outdated Show resolved Hide resolved
src/theme/index.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
fidelman
fidelman suggested changes Oct 18, 2020
View reviewed changes
src/components/layout.tsx Outdated Show resolved Hide resolved
src/components/seo.tsx Outdated Show resolved Hide resolved
src/layouts/DefaultLayout.tsx Show resolved Hide resolved
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from a5e2cc4 to de3c3ec Compare October 19, 2020 19:34
pavelsuraba
pavelsuraba reviewed Oct 19, 2020
View reviewed changes
src/components/seo.tsx Outdated Show resolved Hide resolved
src/components/seo.tsx Outdated Show resolved Hide resolved
@fidelman
Copy link

po zhlédnutí PR jsem měl silný pocit, že přechod k Eslint vypadá jako nějaký downgrade

@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from de3c3ec to de668d5 Compare October 22, 2020 16:16
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from de668d5 to 0a5f7e2 Compare October 22, 2020 16:21
@HormCodes HormCodes requested a review from miiila October 22, 2020 16:25
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from 0a5f7e2 to 2c3fe1a Compare October 22, 2020 16:35
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from 2c3fe1a to 185ab50 Compare October 22, 2020 16:36
@HormCodes HormCodes force-pushed the refactoring/rework/tslint_to_eslint branch from 185ab50 to ebc6a48 Compare October 22, 2020 16:36
@HormCodes
Copy link
Member Author

Za mne je to ready na další review. Snad jsem na nic nezapomněl. 🙂

@HormCodes HormCodes merged commit c301cfd into rework Oct 23, 2020
@HormCodes HormCodes deleted the refactoring/rework/tslint_to_eslint branch October 23, 2020 13:40
@fidelman fidelman mentioned this pull request Nov 2, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelsuraba pavelsuraba pavelsuraba left review comments

@fidelman fidelman fidelman approved these changes

@miiila miiila Awaiting requested review from miiila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HormCodes @fidelman @pavelsuraba @miiila