Unit tests

cesarParra · Oct 15, 2023 · a87d494 · a87d494
1 parent 4d9a335
commit a87d494
Show file tree

Hide file tree

Showing 3 changed files with 108 additions and 2 deletions.
diff --git a/expression-src/main/api/tests/EvaluatorTest.cls b/expression-src/main/api/tests/EvaluatorTest.cls
@@ -1403,4 +1403,72 @@ private class EvaluatorTest {
         Object result = Evaluator.run(formula);
         Assert.areEqual(3, result);
     }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenPassingArgumentToSObjectGetExpr() {
+        Account testRecord = new Account(Name = 'Test');
+        insert testRecord;
+
+        try {
+            Evaluator.run('FETCH("Account", []) -> FIRST().Name("Test")',
+                testRecord.Id);
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenPassingArgumentToMapGetExpr() {
+        try {
+            Evaluator.run('{"Name": "Test"}.Name("Test")');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenGettingFieldThatDoesNotExist() {
+        Account testRecord = new Account(Name = 'Test');
+        insert testRecord;
+
+        try {
+            Evaluator.run('FETCH("Account", []) -> FIRST().NonExistentField',
+                testRecord.Id);
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenGettingKeyThatDoesNotExist() {
+        try {
+            Evaluator.run('{"Name": "Test"}.NonExistentKey');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenBubblingErrorsFromGlobalVariableResolvers() {
+        try {
+            Evaluator.run('$Action.Apex.NonExistentClass');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenUsingGetExpressionInAnInvalidWay() {
+        try {
+            Evaluator.run('$DoesNotExist.DoSomething');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
 }
diff --git a/expression-src/main/api/tests/OperatorTest.cls b/expression-src/main/api/tests/OperatorTest.cls
@@ -115,6 +115,26 @@ private class OperatorTest {
         Assert.areEqual(true, Evaluator.run('1 = 1 && (2 = 2)'));
     }
 
+    @IsTest
+    private static void throwsRuntimeExceptionWhenLeftSideOfDoubleAmpIsNotBoolean() {
+        try {
+            Evaluator.run('1 && 2');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenRightSideOfDoubleAmpIsNotBoolean() {
+        try {
+            Evaluator.run('1 = 1 && 2');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
     @IsTest
     private static void supportsAnd_leftFalse() {
         Assert.areEqual(false, Evaluator.run('1 = 2 && 2 = 2'));
@@ -130,6 +150,26 @@ private class OperatorTest {
         Assert.areEqual(true, Evaluator.run('((1 = 1) && (2 = 2)) || (3 = 3)'));
     }
 
+    @IsTest
+    private static void throwsRuntimeExceptionWhenLeftSideOfDoublePipeIsNotBoolean() {
+        try {
+            Evaluator.run('1 || 2');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
+    @IsTest
+    private static void throwsRuntimeExceptionWhenRightSideOfDoublePipeIsNotBoolean() {
+        try {
+            Evaluator.run('1 != 1 || 2');
+            Assert.fail('Expected RuntimeException');
+        } catch (Exception e) {
+            Assert.isInstanceOfType(e, Exceptions.RuntimeException.class);
+        }
+    }
+
     @IsTest
     private static void supportsOr() {
         Assert.areEqual(true, Evaluator.run('1 = 1 || (2 = 2)'));

diff --git a/expression-src/main/src/interpreter/Scanner.cls b/expression-src/main/src/interpreter/Scanner.cls
@@ -171,8 +171,6 @@ public with sharing class Scanner {
         // want the column of the first line.
         List<String> textLines = text.split('\n');
         Integer column = this.column - textLines[0].length();
-        System.debug('current col ' + this.column);
-        System.debug('text lines ' + textLines[0]);
 
         tokens.add(new Token(type, text, literal, new Token.Position(line, column)));
     }