Log count of processed messages configurable #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
component: core
feature
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
+ Coverage 77.98% 78.04% +0.06%
==========================================
Files 221 221
Lines 9047 9070 +23
==========================================
+ Hits 7055 7079 +24
+ Misses 1992 1991 -1
Continue to review full report at Codecov.
|
dmth
approved these changes
May 24, 2017
There was a problem hiding this comment.
Thank you for implementing this.
I did not run the code, but it looks ok.
Have you implemented your idea from #743 (comment), also?
Thanks for the reminder. Did that including tests and also merged master. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now configurable how often the "Processed .. messages" is logged. You can give a count and seconds.
See #743