FIX: Correctly configure SSL context for AMQP #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Python documentation, in order to establish a client-side connection the purpose of SERVER_AUTH is appropriate. It instructs the SSL libraries to verify the authenticity of the server. As of Python 3.10 [2], the internal configuration used has been changed from the generic PROTOCOL_TLS to a specific variant for client or server. Therefore, when using Python 3.10 or higher, the incorrect configuration of ssl.Purpose results in an inability to establish a connection. [1] https://docs.python.org/3/library/ssl.html#ssl.Purpose.SERVER_AUTH [2] https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS
kamil-certat
added
bug
gethvi
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Python documentation, in order to establish
a client-side connection the purpose of SERVER_AUTH is appropriate.
It instructs the SSL libraries to verify the authenticity
of the server. As of Python 3.10 [2], the internal configuration
used has been changed from the generic PROTOCOL_TLS to a specific
variant for client or server. Therefore, when using Python 3.10
or higher, the incorrect configuration of ssl.Purpose results
in an inability to establish a connection.
[1] https://docs.python.org/3/library/ssl.html#ssl.Purpose.SERVER_AUTH
[2] https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS