fix: analysis total time overstated - show max time #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not 100% accurate get as we are using the max value, instead of summing unique paths in the stack.
lcottercertinia
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the TotalTime column to show max time.
This is more accurate but will not show an accurate number until we change the logic to sum unique paths in the stack.
Filtering could easily break this.
For example filter by namespace and now the only two methods in the analysis are siblings
Method 1 in pkg1 calls to Method2 and Method 3 in pkg2
Filter by pkg2 and both Method2 and Method3 should be included in the total with this change only the largest will be.
There will be a follow fix to be accurate
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
Related Issue #526
fixes #
resolves #
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?