perf: parser speed (lexer rework) #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing parsing of a large 70mb log went from ~2s to 1.3s, roughly 35% (~1.3 times) faster. - Improved performance by reducing down to 1 loop when creating and parsing log lines (generator function). - Instead of placing all the line strings in memory upfront (giant array), we do it as each line needs them. - The line iterator now only has one line in memory. - Avoid high GC cost by manually splitting strings on new line character instead of using string split.
|
Need to merge namespace work first |
Return namespace from a cache and avoid allocating extra strings to do the same namespace parsing work repeatedly.
This wil reduce the num of condition check needed
This reduce number of right hands boolean condtion checks when left hand side is already true.
It already is an array
lcottercertinia
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parser performance improvement from v1.12.1
Testing shows between 1.5 and 2.7 times faster performance.
This is mainly down to
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
Related Issue #475
fixes #
resolves #
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?