feat: parser performance #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for the string split to use a specific and better performing regex
In order to support mixed line endings
The new method is just over 3 times faster (70% faster) For a given log it used to take ~1400ms and now takes ~400ms. This was achieved by bulkifying nodes to processs and avoiding recursion as much as possible.
lcottercertinia
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parser performance improvements .
Improved parseTimestamp and parseLineNumber, line number had a fast path added for EXTERNAL.
Switched from for loops to while loops in some cases.
faster aggregate totals function
The new method is just over 3 times faster (70% faster)
For a given log I tested with it used to take ~1400ms and now takes ~400ms.
This was achieved by bulkifying nodes to process and avoiding recursion as much as possible.
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
Related Issue #299 #475
fixes #
resolves #
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?