Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open viewer from dirty editor #449

Merged

Conversation

lukecotter
Copy link
Contributor

Description

feat: open viewer with editor content if file does not exist

This is mainly to support drag and drop file in code builder.
It also helps when a file is deleted on local disk or a log is
copy and pasted into an editor window without saving.

Type of change (check all applicable)

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • ⚡ Performance Improvement
  • 📝 Documentation
  • 🔧 Chore
  • 💥 Breaking change

[optional] Any images / gifs / video

Related Tickets & Documents

Related Issue #
fixes #
resolves #213
closes #

Added tests?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

Added to documentation?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • 🙅 not needed

[optional] Are there any post-deployment tasks we need to perform?

This is mainly to support drag and drop file in code builder.
It also helps when a file is deleted on local disk or a log is
copy and pasted into an editor window without saving.
@lcottercertinia lcottercertinia merged commit 35a10ba into certinia:main Nov 20, 2023
3 checks passed
@lukecotter lukecotter deleted the feat-open-viewer-from-dirty-editor branch November 20, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: viewer should work in code builder if file is dragged into browser
2 participants