feat: timeline global info markers improvements #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To distinguish them when two errors are side by side.
It used to be green which normal indicators things are ok. Chnaged to blue to indicate an info level issue.
lcottercertinia
approved these changes
Nov 20, 2023
lukecotter
deleted the
feat-timeline-global-info-markers-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes Skipped-Lines and Max-Size-reached marker color from green to blue. Green normal mean things are ok, blue better represents information.
Adds faint grey lines between the event markers to seperates them. This helps when two error are next to each other.
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
Related Issue #
fixes #
resolves #115
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?