Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI housekeeping #52

Merged
merged 1 commit into from
Jun 24, 2024
Merged

CI housekeeping #52

merged 1 commit into from
Jun 24, 2024

Conversation

kianmeng
Copy link
Contributor

This PR ensures all CI jobs pass without errors.

List of changes:

  • add support for OTP26/27 in CI
  • bump actions/checkout
  • drop support for OTP19 (not supported in official Docker image) from CI
  • drop support for OTP20 (not supported by rebar3_hex) from CI
  • fix test errors due to updated certs
  • remove Travis CI config
  • resolve dialyzer error of unknown function public_key:pem_decode/1 in OTP26/27

strategy:
matrix:
otp_vsn: ["19.0", "19.3",
"20.0", "20.1.7", "20.3.8.22",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTP 20:

Run rebar3 eunit
===> Analyzing applications...
===> Compiling verl
===> Compiling hex_core
===> Compiling _build/default/plugins/hex_core/src/hex_pb_signed.erl failed
_build/default/plugins/hex_core/src/hex_pb_signed.erl:[6](https://github.com/kianmeng/erlang-certifi/actions/runs/9628138976/job/26556041390#step:5:7)6: not yet implemented 'if'
_build/default/plugins/hex_core/src/hex_pb_signed.erl:[7](https://github.com/kianmeng/erlang-certifi/actions/runs/9628138976/job/26556041390#step:5:8)2: not yet implemented 'if'

===> Errors loading plugin rebar3_hex. Run rebar3 with DEBUG=1 set to see errors.
===> Errors loading plugin rebar3_ex_doc. Run rebar3 with DEBUG=1 set to see errors.
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling certifi
===> Compiling _build/default/plugins/hex_core/src/hex_pb_names.erl failed
_build/default/plugins/hex_core/src/hex_pb_names.erl:76: not yet implemented 'if'
_build/default/plugins/hex_core/src/hex_pb_names.erl:[8](https://github.com/kianmeng/erlang-certifi/actions/runs/9628138976/job/26556041390#step:5:9)2: not yet implemented 'if'

strategy:
matrix:
otp_vsn: ["19.0", "19.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTP 19 not in the official supported Docker image tags.
See https://hub.docker.com/_/erlang/

{dialyzer, [
{plt_extra_apps, [public_key]}
]}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run rebar3 dialyzer
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling certifi
===> Dialyzer starting, this may take a while...
===> Add debug_info to compiler options (erl_opts) if Dialyzer fails to load Core Erlang.
===> Updating plt...
===> Resolving project files...
===> Updating base plt...
===> Resolving base files...
===> Building with 212 files in /home/runner/.cache/rebar3/rebar3_2[6](https://github.com/kianmeng/erlang-certifi/actions/runs/9627560355/job/26554777720#step:6:7).2.5_plt...
===> Copying /home/runner/.cache/rebar3/rebar3_26.2.5_plt to /home/runner/work/erlang-certifi/erlang-certifi/_build/default/rebar3_26.2.5_plt...
===> Checking 212 files in _build/default/rebar3_26.2.5_plt...
===> Doing success typing analysis...
===> Resolving project warning files...
===> Analyzing 2 files with _build/default/rebar3_26.2.5_plt...

./certifi_pt.erl
Line [9](https://github.com/kianmeng/erlang-certifi/actions/runs/9627560355/job/26554777720#step:6:10) Column 10: Unknown function public_key:pem_decode/1
===> Warnings written to _build/default/26.2.5.dialyzer_warnings
===> Warnings occurred running dialyzer: 1
Error: Process completed with exit code 1.

This PR ensures all CI jobs pass without errors.

List of changes:
- add support for OTP26/27 in CI
- bump actions/checkout
- drop support for OTP19 (not supported in official Docker image) from CI
- drop support for OTP20 (not supported by rebar3_hex) from CI
- fix test errors due to updated certs
- remove Travis CI config
- resolve dialyzer error of unknown function public_key:pem_decode/1 in
  OTP26/27
@benoitc benoitc merged commit 1b4fe3c into certifi:master Jun 24, 2024
7 checks passed
@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants