Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart building + ensure BINDIR is created when running targets #38

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Jul 20, 2022

  1. Adds make chart to generate a local helm chart for testing
  2. Creates $(BINDIR) and subdirectories using order only dependencies (see details in the cert-manager repo)
  3. Use $@ where possible
  4. Adds release version as a variable since it's now used in more than one place

I'd probably also advocate changing $(BINDIR) to default to _bin for the same reasons we did that in cert-manager but that seemed maybe a change too far for this PR

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 20, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2022
@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-trust-smoke

Copy link
Contributor

@JoshVanL JoshVanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing from me 🙂

Makefile Outdated Show resolved Hide resolved
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jul 20, 2022
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jul 20, 2022
@SgtCoDFish SgtCoDFish requested a review from JoshVanL July 20, 2022 15:48
@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-trust-verify
/test pull-cert-manager-trust-smoke

@SgtCoDFish
Copy link
Member Author

�[91mfatal: not a git repository (or any of the parent directories): .git

Ah that's really annoying; I'll have to remove the $(RELEASE_VERSION) stuff, don't want to get into touching the docker build ATM

@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-trust-smoke

1 similar comment
@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-trust-smoke

@SgtCoDFish
Copy link
Member Author

Smoke test failures were legit, hopefully fixed now 😁

@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-trust-verify

@SgtCoDFish SgtCoDFish dismissed JoshVanL’s stale review July 21, 2022 09:27

Comments addressed

@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@jetstack-bot jetstack-bot merged commit 1d71e86 into cert-manager:main Jul 21, 2022
@SgtCoDFish SgtCoDFish deleted the bindir branch July 21, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants