-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chart building + ensure BINDIR is created when running targets #38
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cert-manager-trust-smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing from me 🙂
/test pull-cert-manager-trust-verify |
Ah that's really annoying; I'll have to remove the |
/test pull-cert-manager-trust-smoke |
1 similar comment
/test pull-cert-manager-trust-smoke |
Signed-off-by: Ashley Davis <[email protected]>
Smoke test failures were legit, hopefully fixed now 😁 |
/test pull-cert-manager-trust-verify |
/lgtm |
make chart
to generate a local helm chart for testing$(BINDIR)
and subdirectories using order only dependencies (see details in the cert-manager repo)$@
where possibleI'd probably also advocate changing
$(BINDIR)
to default to_bin
for the same reasons we did that in cert-manager but that seemed maybe a change too far for this PR