Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all linter issues and un-ignore golanci-lint linter exceptions #360

Merged
merged 21 commits into from
May 23, 2024
Merged

Fix all linter issues and un-ignore golanci-lint linter exceptions #360

merged 21 commits into from
May 23, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented May 23, 2024 •
edited
Loading

Each commit removes one linter exception.

inteon added 21 commits May 23, 2024 09:38
@inteon
fix gci linter
dacde35 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix mirror linter
82f0913 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix misspell linter
0858127 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix unused linter
c7b1950 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gofmt linter
b272cf4 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix unconvert linter
2b1e726 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gocritic linter
e02f091 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix ineffassign linter
951227e 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix wastedassign linter
ddfea7d 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix typecheck linter
b48a6db 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix staticcheck linter
e3d6738 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gosimple linter
d19a66f 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix prealloc linter
56a48e9 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix errorlint linter
be054d8 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gosec linter
3b0c6e9 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix containedctx linter
11263d4 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix contextcheck linter
434185e 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix unparam linter
a037842 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix errcheck linter
7b99dda 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix promlinter linter
5a82d25 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix dupword linter
91fe50f 
Signed-off-by: Tim Ramlot <[email protected]>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label May 23, 2024
@inteon inteon changed the title Fix all linter issues and Un-ignore golanci-lint linter exceptions Fix all linter issues and un-ignore golanci-lint linter exceptions May 23, 2024
@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2024
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@erikgb
Copy link
Contributor

erikgb commented May 23, 2024

LGTM, but build is failing because of invalid checksum for "/home/prow/go/src/github.com/cert-manager/trust-manager/_bin/downloaded/tools/kubebuilder_tools_1.30.0_linux_amd64.tar.gz.tmp": wanted "d51dae845397b7548444157903f2d573493afb6f90ce9417c0f5c61d4b1f908d" but got "00fb1322a3da606e90586d2327abe797cea3a6e199a37d3bb2fbef6d8f5fc6bb"

@inteon
Copy link
Member Author

inteon commented May 23, 2024

/retest

@inteon
Copy link
Member Author

inteon commented May 23, 2024

LGTM, but build is failing because of invalid checksum for "/home/prow/go/src/github.com/cert-manager/trust-manager/_bin/downloaded/tools/kubebuilder_tools_1.30.0_linux_amd64.tar.gz.tmp": wanted "d51dae845397b7548444157903f2d573493afb6f90ce9417c0f5c61d4b1f908d" but got "00fb1322a3da606e90586d2327abe797cea3a6e199a37d3bb2fbef6d8f5fc6bb"

Should have been fixed in #361.

@erikgb
Copy link
Contributor

erikgb commented May 23, 2024

Thanks a lot for fixing this @inteon!

/lgtm
/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@cert-manager-prow cert-manager-prow bot merged commit dddde13 into cert-manager:main May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @ThatsMrTalbot @erikgb