-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Makefile
s reusable and automate release process
#195
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4956df7
to
bd6e51e
Compare
6f8fe69
to
5e22cf6
Compare
34d928c
to
6906bde
Compare
874f9a0
to
eedc3df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I spotted!
I think it'd be nice and not too difficult to roll this change out in a way that doesn't require breaking the tests at any point, but I guess we can always roll the tests back so I don't think that's a requirement.
EDIT: That said, since the tests are failing right now maybe that would be a good idea so we can have some confidence before we merge
Signed-off-by: Tim Ramlot <[email protected]>
…kage target Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
@SgtCoDFish I re-added the old make targets for backwards compatibility, now we don't have to break the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
I think this is good to go and kudos to @inteon for the effort it took to get this done.
I'm adding a hold because Tim isn't working today as far as I can tell (despite the updates he made this morning!). This can wait until Monday to merge, and then Tim should be available to help with the followup PRs to cleanup the testing repo / remove the deprecated make targets afterwards.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
fi | ||
|
||
echo "{}" | jq \ | ||
--rawfile bundle /etc/ssl/certs/ca-certificates.crt \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: IMPORTANT
I missed this during the review. I shouldn't have missed it and it'll need to fixed.
This uses the system's trust-bundle, not the one from the container.
It breaks development on all platforms which aren't Debian-based linux (e.g. macOS, RHEL, etc)
It shouldn't lead to an incorrect bundle being pushed upstream, but it needs fixing as a matter of urgency in case that changes in the future.
See #355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing & fixing @SgtCoDFish!
I made a typo indeed.
ref: cert-manager/makefile-modules#3
Note
The trust-bundle adds some extra complexity
oci-maybe-push-package_debian
action to make sure the referenced trust package exists.ℹ️ I tested these changes on my personal branch and fixed all remaining issues in the release process.