Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Rename "Bundle" to "ClusterBundle" #63

Open
Tracked by #242
evankanderson opened this issue Oct 27, 2022 · 9 comments
Open
Tracked by #242

nit: Rename "Bundle" to "ClusterBundle" #63

evankanderson opened this issue Oct 27, 2022 · 9 comments

Comments

@evankanderson
Copy link

Since Bundle is cluster-scoped, ClusterBundle seems like it would be the proper name (which seems correct, given that spec.target.namespaceSelector suggests that the Bundle should be at a Cluster scope or need an "AcceptBundle" object in each namespace to indicate that the namespace wants to receive the certs).

@SgtCoDFish
Copy link
Member

SgtCoDFish commented Jan 10, 2023

Agree with ClusterBundle being a better match for current behaviour, although IIRC from past conversations amongst the maintainer team I've made the case for us to change Bundle to default to only write the target in a single namespace, with the option to write to all.

In any case, I think the behaviour of writing to all namespaces shouldn't be the default and I feel like Bundle would fit pretty well in that case. What do you think?

(Thank you for your contribution!)


EDIT: See #39 which I actually raised about changing the behaviour!

@ProbstDJakob
Copy link

I think ClusterBundle is still a better name since it does not belong to a single namespace. Furthermore this would allow adding a Bundle CRD which is bound to a namespace later. Much like ClusterIssure and Issuer. (See also #131 (comment))

@erikgb
Copy link
Contributor

erikgb commented Nov 17, 2023

/milestone trust-manager v1

@jetstack-bot
Copy link
Contributor

@erikgb: You must be a member of the cert-manager/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone trust-manager v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish added this to the trust-manager v1 milestone Nov 17, 2023
@SgtCoDFish
Copy link
Member

(Added to milestone, annoying that there's another group for it!)

FWIW I agree about Bundle / ClusterBundle now. I see the use case and I think it's worth renaming the resource we currently have to ClusterBundle. I also see the value in adding Bundle as a namespace-scoped resource, but I'm currently inclined to think we don't need to do both things at once.

I suspect we'll make the rename from Bundle -> ClusterBundle in v1alpha2 or v1beta1, which is on the roadmap after us hearing so much demand for trust-manager v1 at KubeCon NA in Chicago!

@cert-manager-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@cert-manager-prow cert-manager-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
@erikgb
Copy link
Contributor

erikgb commented Nov 6, 2024

/remove-lifecycle stale

@cert-manager-prow cert-manager-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
@erikgb
Copy link
Contributor

erikgb commented Nov 23, 2024

I think we should move forward on this, and wanted to discuss the best approach in our last bi-weekly meeting. But I am eager, so I asked for advice on Slack and got good feedback from Bryce Palmer in Red Hat. ❤️ Here's a link to the thread.

Regardless of the details of how we will do this, I think it is mandatory to fix #99 first. And at least allow for at least one release (ideally multiple) with an owner-ref option included before we rename the kind/resource from Bundle to ClusterBundle. I am starting to look at #99 now, and will add my suggestion to the issue.

@sftim
Copy link

sftim commented Nov 23, 2024

Consider if you want to emit warnings about people using the legacy Bundle name (assuming you can tell - I think you can).

I'd use a ValidatingAdmissionPolicy to actually emit the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants