-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nit: Rename "Bundle" to "ClusterBundle" #63
Comments
Agree with In any case, I think the behaviour of writing to all namespaces shouldn't be the default and I feel like (Thank you for your contribution!) EDIT: See #39 which I actually raised about changing the behaviour! |
I think |
/milestone trust-manager v1 |
@erikgb: You must be a member of the cert-manager/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(Added to milestone, annoying that there's another group for it!) FWIW I agree about Bundle / ClusterBundle now. I see the use case and I think it's worth renaming the resource we currently have to ClusterBundle. I also see the value in adding Bundle as a namespace-scoped resource, but I'm currently inclined to think we don't need to do both things at once. I suspect we'll make the rename from Bundle -> ClusterBundle in v1alpha2 or v1beta1, which is on the roadmap after us hearing so much demand for trust-manager v1 at KubeCon NA in Chicago! |
Issues go stale after 90d of inactivity. |
/remove-lifecycle stale |
I think we should move forward on this, and wanted to discuss the best approach in our last bi-weekly meeting. But I am eager, so I asked for advice on Slack and got good feedback from Bryce Palmer in Red Hat. ❤️ Here's a link to the thread. Regardless of the details of how we will do this, I think it is mandatory to fix #99 first. And at least allow for at least one release (ideally multiple) with an owner-ref option included before we rename the kind/resource from |
Consider if you want to emit warnings about people using the legacy Bundle name (assuming you can tell - I think you can). I'd use a ValidatingAdmissionPolicy to actually emit the warnings. |
Since Bundle is cluster-scoped, ClusterBundle seems like it would be the proper name (which seems correct, given that
spec.target.namespaceSelector
suggests that the Bundle should be at a Cluster scope or need an "AcceptBundle" object in each namespace to indicate that the namespace wants to receive the certs).The text was updated successfully, but these errors were encountered: