Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go dependencies #222

Closed
wants to merge 3 commits into from
Closed

Upgrade Go dependencies #222

wants to merge 3 commits into from

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Dec 5, 2023

No description provided.

wallrj added 2 commits December 5, 2023 12:12
@wallrj
Upgrade all dependencies using go-mod-upgrade
51fa251 
go-mod-upgrade
go mod tidy
go get istio.io/istio@latest

Signed-off-by: Richard Wall <[email protected]>
@wallrj
Upgrade hack/tools using go-mod-upgrade
8a51405 
Signed-off-by: Richard Wall <[email protected]>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 5, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wallrj. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2023
@wallrj
Downgrade istio.io/api for to fix compilation error
9e042cc 
$ go vet ./...
../../../go/pkg/mod/istio.io/[email protected]/pkg/config/validation/validation.go:2247:32: rule.FromCookies undefined (type *"istio.io/api/security/v1beta1".JWTRule has no field or method FromCookies)

$ go get istio.io/[email protected]
go: downgraded istio.io/api v1.20.0 => v1.19.0-alpha.1.0.20231130210426-342d60d7bee6

$ go vet ./...

$ go mod tidy

Signed-off-by: Richard Wall <[email protected]>
@wallrj wallrj mentioned this pull request Dec 5, 2023
Open
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2024
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

@wallrj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-15 9e042cc link true /test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-15
pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-16 9e042cc link true /test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-16
pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-17 9e042cc link true /test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-17
pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-14 9e042cc link true /test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-14
pull-cert-manager-istio-csr-unit 9e042cc link true /test pull-cert-manager-istio-csr-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wallrj wallrj closed this Jan 8, 2024
@wallrj wallrj deleted the upgrade-dependencies branch January 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallrj @jetstack-bot