Add ARM testing #327
Add ARM testing #327
Conversation
bmsiegel
force-pushed
the
main
branch
3 times, most recently
from
2d5f7a1
to
88365bf
Compare
| run: | | ||
| make helm-test | ||
| - name: Copy Kind logs to S3 | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'chart update') }} | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'chart update') && inputs.architecture != 'arm64' }} |
There was a problem hiding this comment.
So I get skipping the helm test but why skip terminating the cluster and copying the kind cluster logs to s3 for ARM?
There was a problem hiding this comment.
The kind cluster is deleted in the step before, this cluster is just used for helm test
There was a problem hiding this comment.
Got it, yeah it would be nice when we re-visit the helm test if we just broke these steps out and grouped them together as a helm test workflow.
Signed-off-by: Brady Siegel <[email protected]>
| run: | | ||
| make helm-test | ||
| - name: Copy Kind logs to S3 | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'chart update') }} | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'chart update') && inputs.architecture != 'arm64' }} |
There was a problem hiding this comment.
Got it, yeah it would be nice when we re-visit the helm test if we just broke these steps out and grouped them together as a helm test workflow.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: anbaig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addresses #283. Thank you to those who worked on #319 , pulled a lot of the code to make this testing work from there.
Successful testing run: https://github.com/bmsiegel/aws-privateca-issuer/actions/runs/9651463359
Let's merge the testing, then we'll get the ARM support PR merged. Will leave some comments on #319