docs: brush-up policy examples #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
brush-up-examples
branch
from
54b19e9 to
99c3496
Compare
inteon
reviewed
Nov 26, 2023
inteon
reviewed
Nov 26, 2023
Signed-off-by: Tim Ramlot <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While considering a doc update PR in our website project to add some docs around the new CEL validations feature, I noticed that our docs link to policy examples in this repo. We should have some examples showing how the new CEL validation feature can be used, so I updated the all-options example to really use all options.
In addition, I removed the repeated RBAC setup for all examples. IMO the examples here should be policy examples.
I also removed the last occurrence of the slightly confusing term "impossible condition" in this project. 😉