This repository has been archived by the owner on May 22, 2024. It is now read-only.
[terra-functional-testing] Remove axe option from the Terra Service #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenEsser
requested review from
dkasper-was-taken,
emilyrohrbough,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
Comment on lines
+19
to
+21
| const globalRuleArray = Object.keys(Terra.axe.rules).map((rule) => ( | ||
| { ...Terra.axe.rules[rule], id: rule } | ||
| )); |
There was a problem hiding this comment.
Suggested change
| const globalRuleArray = Object.keys(Terra.axe.rules).map((rule) => ( | |
| { ...Terra.axe.rules[rule], id: rule } | |
| )); | |
| const globalRuleArray = Object.entries(Terra.axe.rules).map((rule, settings) => ( | |
| { ...settings, id: rule } | |
| )); |
emilyrohrbough
approved these changes
Nov 4, 2020
yuderekyu
approved these changes
Nov 4, 2020
benbcai
reviewed
Nov 4, 2020
| const { formFactor, theme } = options; | ||
|
|
||
| this.formFactor = formFactor; | ||
| this.theme = theme || 'terra-default-theme'; |
There was a problem hiding this comment.
In #464 I'm exposing the entire service options object thru Terra.serviceOptions. I should probably default Terra.serviceOptions.theme to terrra-default-theme to keep them in sync. Would it be better to default the theme to terrra-default-theme in wdio.config.js or are we concerned that this config may get overridden by consumers.
There was a problem hiding this comment.
I think the TerraService should default the option if it needs a default rather than requiring a theme be set in the wdio.config
benbcai
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
axeoverride from the Terra Service configuration options. These rules are now set explicitly by the service.Resolves #463
Additional Details
To remove the
axeoption athemeoption was required to properly configure the axe rules based on the current theme. The theme is currently used for the lowlight theme to adjust the color contrast rules.https://github.com/cerner/terra-toolkit-boneyard/blob/main/config/wdio/wdio.conf.js#L100-L102
@cerner/terra