Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-form-select] Fix Search field value clears out issue #4103

Merged
merged 5 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/terra-form-select/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@

## Unreleased

* Fixed
* Search field value now persists when navigating to another component.

## 6.62.1 - (May 13, 2024)

* Fixed
* Fixed a "prop not recognized" console error.


## 6.62.0 - (May 8, 2024)

* Added
Expand Down
7 changes: 3 additions & 4 deletions packages/terra-form-select/src/search/Frame.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,9 @@ class Frame extends React.Component {
this.setState({ isFocused: false, focusedByTouch: false });

if (this.state.hasSearchChanged) {
this.setState({
searchValue: this.props.display,
hasSearchChanged: false,
});
this.setState((prevState) => ({
searchValue: prevState.searchValue.trim(),
}));
}

this.closeDropdown();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Contributor

@saket2403 saket2403 May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the placeholders in all the screenshots?

Copy link
Collaborator Author

@adavijit adavijit May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual tests are passing as per the wdio tests. Check from the deployment link.
I am not sure how empty placeholders are coming in the screenshot difference

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the issue causing screenshot mismatch.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
27 changes: 27 additions & 0 deletions packages/terra-form-select/tests/wdio/select-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1795,6 +1795,33 @@ Terra.describeViewports('Select', ['tiny'], () => {

after(() => $('#root').click());
});

describe('should retain input value on fucusing another component', () => {
it('retain input and focus using tab key', () => {
$('[data-terra-select]').click();
const input = $('[data-terra-select-combobox] input');
input.setValue('Test');

// Pressing Tab key twice to focus the body
browser.keys('Tab');
browser.keys('Tab');

expect($('body')).toBeFocused();
expect(input).toHaveValue('Test');
});

it('should retain input value and focus body when body is clicked', () => {
const input = $('[data-terra-select-combobox] input');

$('[data-terra-select]').click();
input.setValue('Test');

$('body').click();

expect($('body')).toBeFocused();
expect(input).toHaveValue('Test');
});
});
});

describe('Search Variant - controlled', () => {
Expand Down
Loading