This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-dropdown-split-button] Added dashed border on split button when its get focussed #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
approved these changes
Oct 17, 2023
supreethmr
approved these changes
Oct 18, 2023
|
I reviewed the dashed focus indicator and it is working as expected in Edge on PC and Chrome on Mac. |
|
+1 for dashed focus indicator. Verified in Safari/MAC and Edge/Windows. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the dashed border when the split button gets focussed. Previously we can see the blue box shadow and now the blue box shadow has been removed and dashed border has been added.
What was changed:
Split button focus border has been changed to dashed border.
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-7983
Thank you for contributing to Terra.
@cerner/terra
Before changes
After Chnages
