This repository has been archived by the owner on May 24, 2024. It is now read-only.
Fix Utility Menu auto closing issue #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilpfeiffer
requested review from
neilpfeiffer
and removed request for
benbcai
saket2403
approved these changes
Nov 9, 2022
JessieRandle
temporarily deployed
to
terra-applic-fix-utilit-kwytzz
JessieRandle
temporarily deployed
to
terra-applic-fix-utilit-kwytzz
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
userAction Button was not provided with
generateMenuClosingCallbackcallback. This caused utility menu to stay open on userActionButton click.PR fixes this issue by calling
generateMenuClosingCallbackfor userActionCallbackCloses #UXPLATFORM-7901
Deployment Link
https://terra-applic-.herokuapp.com/
Testing
Verified with WDIO screenshots to ensure utility menu is closed after userActionButton is clicked.
Additional Details
Thank you for contributing to Terra.
@cerner/terra