This repository has been archived by the owner on May 24, 2024. It is now read-only.
Fixes Multiple Id inert-style issue
#300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
changed the title
inert-style issue
supreethmr
requested review from
BenBoersma,
saket2403,
sdadn,
ShettyAkarsh and
xenoworf
saket2403
approved these changes
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Element.prototype.hasOwnProperty('inert')is included in application-base to check ifinertpolyfill is required. In Latest release ofwicg-inert-3.1.2Elementhas been replaced withHTMLElementThis was causing accessibility test failures across the consuming projects.https://github.com/WICG/inert/pull/182/files
This PR locks
wicg-inertversion to prevent disruptive test failures in future.Closes #
Deployment Link
https://terra-applic-.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra