Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check client existance and provisioning app in setup_test() #52

Closed
wants to merge 2 commits into from

Conversation

nickvergessen
Copy link
Contributor

  1. Check whether the sync client command exists (!= 127) Be more careful/verbose when ignoring the return_code of the client owncloud/smashbox#99
  2. Log client version as info()
  3. Check if the admin login works
  4. Check if the provisioning app is enabled smashbox gets stuck if provisioning API is disabled owncloud/smashbox#126

Those checks are needed (tests can't work without them, no user creation etc.) so failing and exit(1)

@moscicki

Fix owncloud#126

@@ -26,6 +27,32 @@ def setup_test():
If exception is raised then the testcase execution is aborted and smashbox terminates with non-zero exit code,

"""
cmd = config.oc_sync_cmd
if cmd[0 - len(' --trust'):] == ' --trust':
cmd = cmd[:0 - len(' --trust')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? --trust and --version cannot be specified together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i reported it to the client team, but for now I check for it and remove it. Basically it can only have one option atm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look on test_manager pull request. What about creating a class called test_manager, instead of creating just a raw function? It will enable to add much more plugins to the smashbox, just adding another class to the Test_Manager class itself. Including the checks which are performed in the following changes

@moscicki
Copy link
Contributor

Haven't forgotten about this. But it will need to wait some time more, sorry. I hope this does not prevent you from working on your branch.

@nickvergessen
Copy link
Contributor Author

Yes no problem at the moment.just helps to spot errors earlier but if it works its all fine, so no need to rush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smashbox gets stuck if provisioning API is disabled
3 participants