-
Notifications
You must be signed in to change notification settings - Fork 2
Tracing #22
base: cernbox
Are you sure you want to change the base?
Tracing #22
Conversation
@gmgigi96 @glpatcern this may look it's a big PR with many crucial changes but is not. Most changes are just adding the instrumentation to the code, modulo there is some refactoring of the tracing logic. I would like to test this PR in the QA environment to start getting some load to find perf limits, however I prefer to follow the typical release cycle to merge this and generate a new version that will be deployed only on QA. I went with Vasco through the code and looks good, the configuration is already in Puppet. Please do a review as well and then we can tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to go ahead for QA field tests. My only comment would be on the style of coding the SpanStart
calls spread over the whole code base, which all look like:
r, span := tracing.SpanStartFromRequest(r, tracerName, "<name of the function>")
or
ctx, span := tracing.SpanStartFromContext(ctx, tracerName, "<name of the function>")
where the name of the function
is hard coded each time. If some reflection logic could be used, that could be worked out from the calling stack instead, but I'm not sure this is at all possible in Go.
614bc7e
to
66a8adc
Compare
tracing: refactor
fix go.sum
tracing: refactor registry
tracing: refactor
… ocmshareprovider, permissions, preferences, publicshareprovider, helloworld, publicstorageprovider, userprovider and usershareprovider GRPC services
…n the request and refactor otelhttp handler application
… helloworld, mentix, meshdirectory, metrics, ocmd, preferences, prometheus, reverseprocy, siteacc, sysinfo and welknown HTTP service with opentelemetry
…and auth packages
9177004
to
5b1b632
Compare
No description provided.