Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask integration v2 #10

Open
wants to merge 3 commits into
base: fastpuppi_v1_dask
Choose a base branch
from

Conversation

GintasS
Copy link

@GintasS GintasS commented Apr 24, 2024

A version of dask integration with the logic following: https://stackoverflow.com/questions/71874244/using-dask-to-fill-boost-histograms-stored-in-class-in-parallel .

Issues:

  • The charts are not the same as per the original uproot example. My implementation (like the StackOverflow one) is based on the fact that the histogram is only filled once. The original (uproot) example fills the same histogram multiple times
  • self.h_n histogram does not work, need to investigate.

The solution works like this:

  1. Reads .ROOT files sequentially.
  2. Computes histograms by lazily creating the whole histogram object at once (all_histogram_actions_TH1F function). This function produces dask-delayed objects. All of these dask-delayed objects are then aggregated via computeHistos.
  3. Calling dask.compute() on the histograms.
  4. Writing histograms via the old writeHistos function.

Performance sheet:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant